fix: remove port definitions from service monitor configurations

Signed-off-by: zhenyus <zhenyus@mathmast.com>

freeleaps/helm-pkg/authentication/templates/authentication/servicemonitor.yaml

@@ -1,21 +1,29 @@
-{{- if .Values.authentication.serviceMonitor.enabled }}
+{{ $namespace := .Release.Namespace }}
+{{ $appVersion := .Chart.AppVersion | quote }}
+{{ $releaseService := .Release.Service }}
+{{ $releaseName := .Release.Name }}
+{{ $serviceMonitorEnabled := .Values.authentication.serviceMonitor.enabled }}
+
+{{- if $serviceMonitorEnabled }}
+{{- range $service := .Values.authentication.services }}
+---
 apiVersion: monitoring.coreos.com/v1
 kind: ServiceMonitor
 metadata:
-  name: {{ .Release.Name }}-service-monitor
+  name: {{ $service.name }}-service-monitor
   namespace: {{ .Values.authentication.serviceMonitor.namespace }}
   labels:
-    app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
+    app.kubernetes.io/version: {{ $appVersion }}
-    app.kubernetes.io/name: {{ .Release.Name }}-service-monitor
+    app.kubernetes.io/name: {{ $service.name }}-service-monitor
-    app.kubernetes.io/managed-by: {{ .Release.Service }}
+    app.kubernetes.io/managed-by: {{ $releaseService }}
-    app.kubernetes.io/instance: {{ .Release.Name }}
+    app.kubernetes.io/instance: {{ $releaseName }}
     {{- if .Values.authentication.serviceMonitor.labels }}
     {{- toYaml .Values.authentication.serviceMonitor.labels | nindent 4 }}
     {{- end }}
 spec:
   endpoints:
     - path: /api/_/metrics
-    targetPort: {{ .Values.authentication.serviceMonitor.port }}
+      targetPort: {{ $service.targetPort }}
       {{- if .Values.authentication.serviceMonitor.interval }}
       interval: {{ .Values.authentication.serviceMonitor.interval }}
       {{- end }}
@@ -24,9 +32,12 @@ spec:
       {{- end }}
   namespaceSelector:
     matchNames:
-    - {{ .Release.Namespace | quote }}
+      - {{ $namespace | quote }}
   selector:
     matchLabels:
-      app.kubernetes.io/instance: {{ .Release.Name }}
+      app.kubernetes.io/version: {{ $appVersion }}
-      app.kubernetes.io/name: {{ .Release.Name }}
+      app.kubernetes.io/name: {{ $service.name }}
+      app.kubernetes.io/managed-by: {{ $releaseService }}
+      app.kubernetes.io/instance: {{ $releaseName }}
+{{- end }}
 {{- end }}

freeleaps/helm-pkg/authentication/values.prod.yaml

@@ -45,7 +45,6 @@ authentication:
         terminationGracePeriodSeconds: 30
   serviceMonitor:
     enabled: true
-    port: 8004
     labels:
       release: kube-prometheus-stack
     namespace: freeleaps-monitoring-system

freeleaps/helm-pkg/authentication/values.yaml

@@ -25,7 +25,6 @@ authentication:
   probes: {}
   serviceMonitor:
     enabled: false
-    port: 8004
     labels: {}
     namespace: ""
     internal: 30s

freeleaps/helm-pkg/centralStorage/templates/central-storage/servicemonitor.yaml

@@ -1,21 +1,29 @@
-{{- if .Values.centralStorage.serviceMonitor.enabled }}
+{{ $namespace := .Release.Namespace }}
+{{ $appVersion := .Chart.AppVersion | quote }}
+{{ $releaseService := .Release.Service }}
+{{ $releaseName := .Release.Name }}
+{{ $serviceMonitorEnabled := .Values.centralStorage.serviceMonitor.enabled }}
+
+{{- if $serviceMonitorEnabled }}
+{{- range $service := .Values.centralStorage.services }}
+---
 apiVersion: monitoring.coreos.com/v1
 kind: ServiceMonitor
 metadata:
-  name: {{ .Release.Name }}-service-monitor
+  name: {{ $service.name }}-service-monitor
   namespace: {{ .Values.centralStorage.serviceMonitor.namespace }}
   labels:
-    app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
+    app.kubernetes.io/version: {{ $appVersion }}
-    app.kubernetes.io/name: {{ .Release.Name }}-service-monitor
+    app.kubernetes.io/name: {{ $service.name }}-service-monitor
-    app.kubernetes.io/managed-by: {{ .Release.Service }}
+    app.kubernetes.io/managed-by: {{ $releaseService }}
-    app.kubernetes.io/instance: {{ .Release.Name }}
+    app.kubernetes.io/instance: {{ $releaseName }}
     {{- if .Values.centralStorage.serviceMonitor.labels }}
     {{- toYaml .Values.centralStorage.serviceMonitor.labels | nindent 4 }}
     {{- end }}
 spec:
   endpoints:
     - path: /api/_/metrics
-    targetPort: {{ .Values.centralStorage.serviceMonitor.port }}
+      targetPort: {{ $service.targetPort }}
       {{- if .Values.centralStorage.serviceMonitor.interval }}
       interval: {{ .Values.centralStorage.serviceMonitor.interval }}
       {{- end }}
@@ -24,9 +32,12 @@ spec:
       {{- end }}
   namespaceSelector:
     matchNames:
-    - {{ .Release.Namespace | quote }}
+      - {{ $namespace | quote }}
   selector:
     matchLabels:
-      app.kubernetes.io/instance: {{ .Release.Name }}
+      app.kubernetes.io/version: {{ $appVersion }}
-      app.kubernetes.io/name: {{ .Release.Name }}
+      app.kubernetes.io/name: {{ $service.name }}
+      app.kubernetes.io/managed-by: {{ $releaseService }}
+      app.kubernetes.io/instance: {{ $releaseName }}
+{{- end }}
 {{- end }}

freeleaps/helm-pkg/centralStorage/values.prod.yaml

@@ -45,7 +45,6 @@ centralStorage:
         terminationGracePeriodSeconds: 30
   serviceMonitor:
     enabled: true
-    port: 8005
     labels:
       release: kube-prometheus-stack
     namespace: freeleaps-monitoring-system

freeleaps/helm-pkg/centralStorage/values.yaml

@@ -25,7 +25,6 @@ central-storage:
   probes: {}
   serviceMonitor:
     enabled: false
-    port: 8005
     labels: {}
     namespace: ""
     internal: 30s

freeleaps/helm-pkg/content/templates/content/servicemonitor.yaml

@@ -1,21 +1,29 @@
-{{- if .Values.content.serviceMonitor.enabled }}
+{{ $namespace := .Release.Namespace }}
+{{ $appVersion := .Chart.AppVersion | quote }}
+{{ $releaseService := .Release.Service }}
+{{ $releaseName := .Release.Name }}
+{{ $serviceMonitorEnabled := .Values.content.serviceMonitor.enabled }}
+
+{{- if $serviceMonitorEnabled }}
+{{- range $service := .Values.content.services }}
+---
 apiVersion: monitoring.coreos.com/v1
 kind: ServiceMonitor
 metadata:
-  name: {{ .Release.Name }}-service-monitor
+  name: {{ $service.name }}-service-monitor
   namespace: {{ .Values.content.serviceMonitor.namespace }}
   labels:
-    app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
+    app.kubernetes.io/version: {{ $appVersion }}
-    app.kubernetes.io/name: {{ .Release.Name }}-service-monitor
+    app.kubernetes.io/name: {{ $service.name }}-service-monitor
-    app.kubernetes.io/managed-by: {{ .Release.Service }}
+    app.kubernetes.io/managed-by: {{ $releaseService }}
-    app.kubernetes.io/instance: {{ .Release.Name }}
+    app.kubernetes.io/instance: {{ $releaseName }}
     {{- if .Values.content.serviceMonitor.labels }}
     {{- toYaml .Values.content.serviceMonitor.labels | nindent 4 }}
     {{- end }}
 spec:
   endpoints:
     - path: /api/_/metrics
-    targetPort: {{ .Values.content.serviceMonitor.port }}
+      targetPort: {{ $service.targetPort }}
       {{- if .Values.content.serviceMonitor.interval }}
       interval: {{ .Values.content.serviceMonitor.interval }}
       {{- end }}
@@ -24,9 +32,12 @@ spec:
       {{- end }}
   namespaceSelector:
     matchNames:
-    - {{ .Release.Namespace | quote }}
+      - {{ $namespace | quote }}
   selector:
     matchLabels:
-      app.kubernetes.io/instance: {{ .Release.Name }}
+      app.kubernetes.io/version: {{ $appVersion }}
-      app.kubernetes.io/name: {{ .Release.Name }}
+      app.kubernetes.io/name: {{ $service.name }}
+      app.kubernetes.io/managed-by: {{ $releaseService }}
+      app.kubernetes.io/instance: {{ $releaseName }}
+{{- end }}
 {{- end }}

freeleaps/helm-pkg/content/values.prod.yaml

@@ -45,7 +45,6 @@ content:
         terminationGracePeriodSeconds: 30
   serviceMonitor:
     enabled: true
-    port: 8013
     labels:
       release: kube-prometheus-stack
     namespace: freeleaps-monitoring-system

freeleaps/helm-pkg/content/values.yaml

@@ -25,7 +25,6 @@ content:
   probes: {}
   serviceMonitor:
     enabled: false
-    port: 8013
     labels: {}
     namespace: ""
     internal: 30s

freeleaps/helm-pkg/notification/templates/notification/servicemonitor.yaml

@@ -1,21 +1,29 @@
-{{- if .Values.notification.serviceMonitor.enabled }}
+{{ $namespace := .Release.Namespace }}
+{{ $appVersion := .Chart.AppVersion | quote }}
+{{ $releaseService := .Release.Service }}
+{{ $releaseName := .Release.Name }}
+{{ $serviceMonitorEnabled := .Values.notification.serviceMonitor.enabled }}
+
+{{- if $serviceMonitorEnabled }}
+{{- range $service := .Values.notification.services }}
+---
 apiVersion: monitoring.coreos.com/v1
 kind: ServiceMonitor
 metadata:
-  name: {{ .Release.Name }}-service-monitor
+  name: {{ $service.name }}-service-monitor
   namespace: {{ .Values.notification.serviceMonitor.namespace }}
   labels:
-    app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
+    app.kubernetes.io/version: {{ $appVersion }}
-    app.kubernetes.io/name: {{ .Release.Name }}-service-monitor
+    app.kubernetes.io/name: {{ $service.name }}-service-monitor
-    app.kubernetes.io/managed-by: {{ .Release.Service }}
+    app.kubernetes.io/managed-by: {{ $releaseService }}
-    app.kubernetes.io/instance: {{ .Release.Name }}
+    app.kubernetes.io/instance: {{ $releaseName }}
     {{- if .Values.notification.serviceMonitor.labels }}
     {{- toYaml .Values.notification.serviceMonitor.labels | nindent 4 }}
     {{- end }}
 spec:
   endpoints:
     - path: /api/_/metrics
-    targetPort: {{ .Values.notification.serviceMonitor.port }}
+      targetPort: {{ $service.targetPort }}
       {{- if .Values.notification.serviceMonitor.interval }}
       interval: {{ .Values.notification.serviceMonitor.interval }}
       {{- end }}
@@ -24,9 +32,12 @@ spec:
       {{- end }}
   namespaceSelector:
     matchNames:
-    - {{ .Release.Namespace | quote }}
+      - {{ $namespace | quote }}
   selector:
     matchLabels:
-      app.kubernetes.io/instance: {{ .Release.Name }}
+      app.kubernetes.io/version: {{ $appVersion }}
-      app.kubernetes.io/name: {{ .Release.Name }}
+      app.kubernetes.io/name: {{ $service.name }}
+      app.kubernetes.io/managed-by: {{ $releaseService }}
+      app.kubernetes.io/instance: {{ $releaseName }}
+{{- end }}
 {{- end }}

freeleaps/helm-pkg/notification/values.prod.yaml

@@ -45,7 +45,6 @@ notification:
         terminationGracePeriodSeconds: 30
   serviceMonitor:
     enabled: true
-    port: 8003
     labels:
       release: kube-prometheus-stack
     namespace: freeleaps-monitoring-system

freeleaps/helm-pkg/notification/values.yaml

@@ -25,7 +25,6 @@ notification:
   probes: {}
   serviceMonitor:
     enabled: false
-    port: 8003
     labels: {}
     namespace: ""
     internal: 30s

freeleaps/helm-pkg/payment/templates/payment/servicemonitor.yaml

@@ -1,21 +1,29 @@
-{{- if .Values.payment.serviceMonitor.enabled }}
+{{ $namespace := .Release.Namespace }}
+{{ $appVersion := .Chart.AppVersion | quote }}
+{{ $releaseService := .Release.Service }}
+{{ $releaseName := .Release.Name }}
+{{ $serviceMonitorEnabled := .Values.payment.serviceMonitor.enabled }}
+
+{{- if $serviceMonitorEnabled }}
+{{- range $service := .Values.payment.services }}
+---
 apiVersion: monitoring.coreos.com/v1
 kind: ServiceMonitor
 metadata:
-  name: {{ .Release.Name }}-service-monitor
+  name: {{ $service.name }}-service-monitor
   namespace: {{ .Values.payment.serviceMonitor.namespace }}
   labels:
-    app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
+    app.kubernetes.io/version: {{ $appVersion }}
-    app.kubernetes.io/name: {{ .Release.Name }}-service-monitor
+    app.kubernetes.io/name: {{ $service.name }}-service-monitor
-    app.kubernetes.io/managed-by: {{ .Release.Service }}
+    app.kubernetes.io/managed-by: {{ $releaseService }}
-    app.kubernetes.io/instance: {{ .Release.Name }}
+    app.kubernetes.io/instance: {{ $releaseName }}
     {{- if .Values.payment.serviceMonitor.labels }}
     {{- toYaml .Values.payment.serviceMonitor.labels | nindent 4 }}
     {{- end }}
 spec:
   endpoints:
     - path: /api/_/metrics
-    targetPort: {{ .Values.payment.serviceMonitor.port }}
+      targetPort: {{ $service.targetPort }}
       {{- if .Values.payment.serviceMonitor.interval }}
       interval: {{ .Values.payment.serviceMonitor.interval }}
       {{- end }}
@@ -24,9 +32,12 @@ spec:
       {{- end }}
   namespaceSelector:
     matchNames:
-    - {{ .Release.Namespace | quote }}
+      - {{ $namespace | quote }}
   selector:
     matchLabels:
-      app.kubernetes.io/instance: {{ .Release.Name }}
+      app.kubernetes.io/version: {{ $appVersion }}
-      app.kubernetes.io/name: {{ .Release.Name }}
+      app.kubernetes.io/name: {{ $service.name }}
+      app.kubernetes.io/managed-by: {{ $releaseService }}
+      app.kubernetes.io/instance: {{ $releaseName }}
+{{- end }}
 {{- end }}

freeleaps/helm-pkg/payment/values.prod.yaml

@@ -45,7 +45,6 @@ payment:
         terminationGracePeriodSeconds: 30
   serviceMonitor:
     enabled: true
-    port: 8006
     labels:
       release: kube-prometheus-stack
     namespace: freeleaps-monitoring-system

freeleaps/helm-pkg/payment/values.yaml

@@ -25,7 +25,6 @@ payment:
   probes: {}
   serviceMonitor:
     enabled: false
-    port: 8006
     labels: {}
     namespace: ""
     internal: 30s